Driver selection #33
Merged
Driver selection #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this won't complain if you try to load a driver that won't work in the browser loaded, so we should probably cover that off before this gets merged in.
Merged
|
r? |
|
In your explanation, do you mean 'WebSQL' instead of WebKit? |
|
Yes, yes I do. (Fixed.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows users to select the driver they want to use (effectively, if they want to force localStorage or choose between WebSQL or IndexedDB on Chrome), but will allow for future patches where something like "Don't use localStorage" (#29) is possible.
Note to @sole: I basically went through everything and started lowercasing
localforageeverywhere. The mixed case was not only confusing, but started to cause weird bugs that existed on Mac but not on Linux. I called the library "localForage" as an allusion to "localStorage", but I'm happy to ditch the "clever" (not really) naming convention if it means more clarity, and I think it's generally annoying to developers to expect them to use mixed-case filenames and library names (see: jQuery is `jquery.js), etc.