feat(setDriver): try the next driver if _initStorage fails #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(localforage.setDriver): try the first driver directly feat(localforage.setDriver): wait for any pending older driver initialization refactor(localforage.setDriver): remove the outer promise in favor of chaining fix(localforage.setDriver): wrap LibaryMethods with ready() refactor(localforage.ready): remove the outer promise in favor of chaining
| callWhenReady(this, LibraryMethods[i]); | ||
| } | ||
|
|
||
| this._wrapLibraryMethodsWithReady(); |
There was a problem hiding this comment.
Abstract into a separate method
thgreasi
changed the title
| self._ready = null; | ||
| function initDriver(supportedDrivers) { | ||
| return function() { | ||
| var crntDriverPos = 0; |
There was a problem hiding this comment.
I'm going to rename this to currentDriverPosition; we have the bytes to spare 😉
|
Sorry this took me ages; I'm very behind on localForage work. All good; I'll tweak that variable name and merge it in now 👍 |
This was referenced Sep 22, 2015
Closed
|
It took me a lot of time to write and some iterations & refactors to bring the code to its final state. So I guess that the time required for reviewing was expected given the complexity & effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #363
Possibly related to #70, #145, #195
Squashed commits :
feat(localforage.setDriver): try the first driver directly
feat(localforage.setDriver): wait for any pending older driver initialization
refactor(localforage.setDriver): remove the outer promise in favor of chaining
fix(localforage.setDriver): wrap LibaryMethods with ready()
refactor(localforage.ready): remove the outer promise in favor of chaining