Add support for binary data to localStorage

[jviereck]

This fixes half of #40 - WebSQL support is outstanding and this is why the test is failing at this point

[tofumatt]

Why this change?

[jviereck]

Good catch. This change was not intended. Reverted the change again.

[tofumatt]

Thanks! :-)

[tofumatt]

(PS: Don't worry too about this not merging cleanly; I'll be sure to add my WebSQL code as another commit in this branch to get the tests working and merge it in by hand.)

[jviereck]

(PS: Don't worry too about this not merging cleanly; I'll be sure to add my WebSQL code as another commit in this branch to get the tests working and merge it in by hand.)

Do you have your current WebSQL code online already to have a look at it?

[tofumatt]

No, I’m currently working on it… I’m hoping it’ll be ready today though.

[tofumatt]

(This is taking longer than expected, and I'm adding a bunch of tests to this as well. I'm hoping this week sometime.)

[jviereck]

No worries. As soon as you have something to look at, I am happy to do
so. Also, feel free to send a PR my way if you want ;)

On 18/02/14 02:32, Matthew Riley MacPherson wrote:

(This is taking longer than expected, and I'm adding a bunch of tests
to this as well. I'm hoping this week sometime.)

—
Reply to this email directly or view it on GitHub
#54 (comment).

[creasy1]

True nube here mea culpa. Still in the dark. I have made the candle. In need of the fire to light my path to illumination.

[tofumatt]

Pull request poetry, it's all the rage!

[creasy1]

Having the gain the equivalent to 1 candlepower of knowledge in the world of code write. I now I'm in need of more like an Epa-candlepower light. 1 x 10e18 more candlesticks before I could begin (forgive the cliche) "To see the Forrest through the trees"

[tofumatt]

I'm going to close this branch as the code is in #73 and that's what will get merged.

[creasy1]

Git account closed in way over my head couldn't justify paying for
something I couldn't use.
On Mar 14, 2014 6:44 PM, "Matthew Riley MacPherson" <
notifications@github.com> wrote:

I'm going to close this branch as the code is in #73https://github.com/mozilla/localForage/pull/73and that's what will get merged.

Reply to this email directly or view it on GitHubhttps://github.com//pull/54#issuecomment-37705099
.