Iamolivinius remove grunt run task #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing the type of a test to make it fail didn't broke |
|
Pushing a commit in a minute! |
thgreasi
approved these changes
Jan 25, 2017
There was a problem hiding this comment.
According to grunt-ts docs ce482b5 should make it equivalent to the --project parameter.
|
Cool, thanks! I don't know much about the TS stuff so appreciate the help 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks to the PR to run the typescript tests via grunt. Closes #613 by implementing it but adding a fix for our new typescript type check run script.
@thgreasi Can you make sure this is okay? The typescript tests don't output anything on my local machine so I can't tell if it's working right, but seems fine.