Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of UnknownProperty by adding more concrete property types #27

Closed
scottanderson opened this issue Apr 23, 2023 · 3 comments · Fixed by #30
Closed

Avoid use of UnknownProperty by adding more concrete property types #27

scottanderson opened this issue Apr 23, 2023 · 3 comments · Fixed by #30
Assignees

Comments

@scottanderson
Copy link
Collaborator

From the test cases present in main, the following properties are being handled by UnknownProperty:

  • FieldPathProperty
  • MulticastInlineDelegateProperty
  • ObjectProperty
@localcc
Copy link
Owner

localcc commented Apr 23, 2023

Unknown property should always stay just in case there are unknown engine changes for a specific game, etc., but hints on how to implement these particular properties can be found inside unreal_asset

@scottanderson scottanderson changed the title Replace UnknownProperty with concrete types Avoid use of UnknownProperty by adding more concrete property types Apr 23, 2023
@scottanderson
Copy link
Collaborator Author

@localcc
Copy link
Owner

localcc commented Apr 23, 2023

I don't think object property is a string, is it a string in a binary file? Uasset object property is just an FPackageIndex
It definitely is a string in gvas

@localcc localcc self-assigned this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants