Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Seek from write() #25

Merged
merged 4 commits into from
Apr 23, 2023
Merged

Remove Seek from write() #25

merged 4 commits into from
Apr 23, 2023

Conversation

scottanderson
Copy link
Collaborator

@scottanderson scottanderson commented Apr 20, 2023 •
edited
Loading

localcc
localcc requested changes Apr 23, 2023
View reviewed changes
src/properties/struct_property.rs Outdated
FloatProperty::new(f32::from(vector.x)).write(cursor, false)?;
FloatProperty::new(f32::from(vector.y)).write(cursor, false)?;
FloatProperty::new(f32::from(vector.z)).write(cursor, false)?;
cursor.write_f32::<LittleEndian>(f32::from(vector.x))?;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #24

@localcc localcc merged commit 4a7dccc into localcc:main Apr 23, 2023
4 checks passed
@scottanderson scottanderson added the enhancement New feature or request label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localcc localcc localcc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottanderson @localcc