Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

44 unable to open save file from journey to the savage planet #45

Conversation

scottanderson
Copy link
Collaborator

No description provided.

let string3 = cursor.read_fstring()?;

Ok(TextProperty::Triple(string1, string2, string3))
} else if component_type == 1 && indicator == 3 {
// Rich text
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the problematic case:

00009fe0:                               11 00 00 00 53 68            ....Sh
00009ff0: 6f 72 74 44 65 73 63 72 69 70 74 69 6f 6e 00 0d  ortDescription..
0000a000: 00 00 00 54 65 78 74 50 72 6f 70 65 72 74 79 00  ...TextProperty.
0000a010: a2 00 00 00 00 00 00 00 00 01 00 00 00 03 02 00  ................
0000a020: 00 00 ff 01 00 00 00 53 00 00 00 55 73 65 20 79  .......S...Use y
0000a030: 6f 75 72 20 73 63 61 6e 6e 65 72 20 74 6f 20 64  our scanner to d
0000a040: 6f 63 75 6d 65 6e 74 20 74 68 65 20 70 6c 61 6e  ocument the plan
0000a050: 65 74 27 73 20 65 63 6f 73 79 73 74 65 6d 0a 0a  et's ecosystem..
0000a060: 4b 69 6e 64 65 78 20 70 72 6f 67 72 65 73 73 3a  Kindex progress:
0000a070: 20 7b 70 72 6f 67 72 65 73 73 7d 20 25 00 01 00   {progress} %...
0000a080: 00 00 09 00 00 00 70 72 6f 67 72 65 73 73 00 04  ......progress..
0000a090: 01 00 00 00 04 02 bc 9c 82 42 01 00 00 00 00 00  .........B......
0000a0a0: 00 00 01 00 00 00 04 01 00 00 00 44 01 00 00 00  ...........D....
0000a0b0: 00 00 00 00 00 00 00 00 00 00 00                 ...........

@localcc
Copy link
Owner

localcc commented Dec 26, 2023

I think the whole text property handling should be changed and instead we should have an FText type and parse it more like the engine does

@localcc
Copy link
Owner

localcc commented Dec 26, 2023

I am going to try and implement that, will open a PR / comment here if it works/doesn't

@localcc
Copy link
Owner

localcc commented Dec 26, 2023

Parsing it closer to how the engine does ended up being much more beneficial and flexible, closing this PR in favor of #47

@localcc localcc closed this Dec 26, 2023
@scottanderson scottanderson deleted the 44-unable-to-open-save-file-from-journey-to-the-savage-planet branch January 31, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants