[2.x] Add but don't enable the Content Lock module #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stephen says this is not quite ready yet. Finn (me) asked about documentation. Should we add some notes to clarify there are optional modules included that can be enabled? README.md? Dev docs? Both? |
ekes
added a commit
that referenced
this pull request
Aug 24, 2023
Squashed commit of the following: commit c2ff5d9 Merge: 90d3d0f 5dc2608 Author: ekes <ekes@iskra.net> Date: Thu Aug 24 17:23:59 2023 +0200 Merge branch '2.x' into feature/2.x/543-content-locl commit 90d3d0f Author: Stephen Cox <stephen@agile.coop> Date: Mon Aug 14 13:37:24 2023 +0100 Don't configure content locking if syncing from config commit 2ca2289 Merge: a6b1b2b 7711669 Author: Stephen Cox <stephen@agile.coop> Date: Mon Aug 14 13:18:51 2023 +0100 Merge branch '2.x' into feature/2.x/543-content-locl commit a6b1b2b Author: Stephen Cox <stephen@agile.coop> Date: Mon Aug 14 13:12:39 2023 +0100 Coding standards fixes commit 73fabb3 Author: Stephen Cox <stephen@agile.coop> Date: Mon Aug 14 13:06:59 2023 +0100 Added test for content lock configuration commit 5328995 Author: Stephen Cox <stephen@agile.coop> Date: Mon Aug 14 12:43:32 2023 +0100 Added localgov_content_lock module to customise content lock settings #543 commit 993d00a Author: Stephen Cox <stephen@agile.coop> Date: Fri Jun 30 13:09:17 2023 +0100 Add but don't enable the Content Lock module #543
ekes
changed the title
ekes
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Approve but merge #611 first. I don't think we should be doing development on 2.x first any more, but porting back from dev on 3.x. Certainly don't want to accidentally be adding features to 2.x without them already being added to 3.x
For the rest I've done a manual test, and automated tests, and merged with current 2.x.
I wondered about putting it in the profile (rather than core), but as it's mainly bring in the dependency in composer and the menu it seems a pretty profile-y thing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543