Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded patches #470 #534 #583

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

keelanfh
Copy link
Member

@keelanfh keelanfh commented Jul 4, 2023

Removing some patches that aren't needed any more as they've been applied upstream.

Closes #470
Closes #534

@keelanfh keelanfh requested a review from stephen-cox July 4, 2023 08:32
@keelanfh
Copy link
Member Author

just occurred to me that removing these would need version bumps too, so maybe not such a good idea.

@keelanfh keelanfh marked this pull request as draft July 14, 2023 08:41
@finnlewis finnlewis marked this pull request as ready for review August 4, 2023 13:56
Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run fine without the patches so all good removing them.

@andybroomfield andybroomfield merged commit 5dc2608 into 2.x Aug 21, 2023
8 checks passed
@andybroomfield andybroomfield deleted the fix/2.x/470-534-remove-patches branch August 21, 2023 13:28
This was referenced Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue 'Fix tests running with paratest' patch not required? Is the gin login patch still needed
4 participants