Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of the unpublised content access patch #678

Merged

Conversation

andybroomfield
Copy link
Contributor

Fix #670

Uses the patch in comment 87.
This is the evolution of our current patch, rather than the shortned version.

Fix #670

Uses the patch in comment 87.
This is the evolution of our current patch, rather than the shortned version.
Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the patch failure which makes me think we should get it sooner than later, but I get different test failures on the update test, so perhaps someone else can double check @finnlewis @ekes @Adnan-cds?

@finnlewis
Copy link
Member

finnlewis commented Feb 20, 2024

The new patch applies, but when running phpunit tests locally, I get:

There was 1 error:

1) Drupal\Tests\localgov\Functional\LocalGovUpdateTest::testUpdate
PHPUnit\Framework\Exception: Segmentation fault (core dumped)

Edit: I also get the same error without the patch.

@finnlewis
Copy link
Member

The patch works, I have created a separate issue for the error I get: #680

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this, make a release, then fix the failing tests which look to be unrelated.

@andybroomfield andybroomfield merged commit 7555978 into 3.x Feb 26, 2024
6 of 8 checks passed
@andybroomfield andybroomfield deleted the fix/3.x-670-update-unpublished-node-reference-patch branch February 26, 2024 10:23
@andybroomfield andybroomfield mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The reference unpublish content patch is failing on Drupal 10.1
4 participants