Hide moderation controls when present on confirmation form page #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #236 Adds a preprocess implementation to the alert banner to hide the moderation controls if they have been displayed when on the confirmation page (status form). Note: This only hides on the confirmation form page eg. /admin/content/alert-banner/18/status If the form is included in another way it will still be present. This way, moderation controls can be placed on an alert banner manage display if a site builder considers that desirable, without interfering with the confirmation form to put an alert banner live.
|
Test by adding a moderation control to the manage display and verify they are not present on the confirmation page, but can still be present under view. |
stephen-cox
approved these changes
Aug 14, 2023
|
Thanks @stephen-cox Sorry I missed out on merge monday but I'll merge this now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #236
Adds a preprocess implementation to the alert banner to hide the moderation controls if they have been displayed when on the confirmation page (status form).
Note: This only hides on the confirmation form page eg.
/admin/content/alert-banner/18/status
If the form is included in another way it will still be present.
This way, moderation controls can be placed on an alert banner manage display if a site builder considers that desirable, without interfering with the confirmation form to put an alert banner live.