Hotfix/245 alert banner with empty link text should show more information but nothing shows #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The original code *changes* the type of the render array from LinkItem to GeneratedLink. - This makes theming the entity slightly unpredictable. - This change supplies the default text *without* changing the type of object provided to Twig. - Re: 245_alert_banner_with_empty_link_text_should_show_more_information_but_nothing_shows
andybroomfield
approved these changes
Aug 7, 2023
Fix #251 During config sync operations, if creating a new alert banner type the visibility field will try to be created, even though that is part of config. This checks if the isSyncing flag is set and skips over the postSave actions as we assume they are part of the config being imported.
…ent banners During import, and in times where the type_of_alert field has been deleted, the getCurrentBanners method will try to perform an entity query, but it needs to check the field is present before adding a sort.
Fix #259 Put use statements in alphabetical order.
Ref #218 Add new annotation to get the alert banner permissions form on the manage alert banner type entity. Also changes the alert banner permissions generator to make sure are assigned to the alert banner entity using BundlePermissionHandlerTrait
As banner types now use path /admin/structure/alert-banner-types
Drops support for Drupal 8 and Drupal less than 9.4 which does not have the BundlePermissionHandlerTrait.
* Fix code deprecations #268 * Test against LGD 2.x with Drupal 9 and LGD 3.x with Drupal 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows More information to show if no link title is entered.
Removed the previous PR code as discussed we went with the
hook_preprocess_fieldsolution