Remove Drupal and drupalSettings from alert banner js #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #284 In Drupal 10 it was discovered that the core/drupal and drupalSettings arn't sent by default. They should be explicitlly declared as dependencies, however we don't actully use these so we can saftley remove them for now.
Adnan-cds
approved these changes
Sep 8, 2023
|
Sweet! Shall we get this merged and do a release @andybroomfield , should make the tests on localgov_project happy again https://github.com/localgovdrupal/localgov_project/actions |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #284
In Drupal 10 it was discovered that the core/drupal and drupalSettings arn't sent by default. They should be explicitlly declared as dependencies, however we don't actully use these so we can saftley remove them for now.