Add and apply new css variables to override heading styles #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markconroy
reviewed
May 17, 2022
css/base/variables.css
Outdated
| @@ -98,6 +98,32 @@ body { | |||
| --font-size-h5: var(--font-size-medium); | |||
| --font-size-h6: var(--font-size-medium); | |||
|
|
|||
| /* Heading colours */ | |||
| --text-colour-dark: #000000; | |||
There was a problem hiding this comment.
I'm a little concerned about setting this as a direct colour rather than to another variable that already exists.
By setting it to equal the variable that it should have already been equating too, we should not break existing sites.
Something like this
--text-colour-dark: var(--color-black);
There was a problem hiding this comment.
Ah yes, I was waiting to see what we were doing with the --text-colour-dark and --text-colour-light field on the microsites, but I'll change this for now and we can change again if we need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.