Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the video to 100% width #207

Merged
merged 1 commit into from
May 24, 2022
Merged

Set the video to 100% width #207

merged 1 commit into from
May 24, 2022

Conversation

msayoung
Copy link
Member

No description provided.

@msayoung msayoung requested a review from markconroy May 24, 2022 15:23
@markconroy markconroy merged commit 90c1edf into 1.x May 24, 2022
@markconroy
Copy link
Member

@msayoung I'm merging this because the CSS is perfect for what we need, but I think we should have a follow up in localgov_subsites for the video field formatter to out put a larger video. Currently it only outputs a 200px wide video.

@msayoung
Copy link
Member Author

@markconroy
I did have a look at that, but as they currently don't have a video template even I decided it made more sense here, where we do have one. But I totally agree :)

@markconroy
Copy link
Member

Not having a template should not matter. The field formatter should still out put the video at a higher quality than 200px. I'm worried that what you have done is exactly right, but we'll be stretching 200px wide videos to 100%, where we should be containing 768px wide videos down to 100% for better video quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants