Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed header searchbox border from none to var(--border) #507

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

bisd
Copy link
Member

@bisd bisd commented Nov 19, 2023

I changed the setting --header-search-input-border: none to --header-search-input-border: var(--border) in variables.css. Hope that is ok?

@bisd bisd linked an issue Nov 19, 2023 that may be closed by this pull request
@markconroy
Copy link
Member

Note: this is a PR to fix the issue in #499

@finnlewis
Copy link
Member

@markconroy you happy enough with this?

@finnlewis
Copy link
Member

Discussing in Merge Monday.

This might place a border on existing websites search form, unless they have specified no border in the child theme.

I will test it and generate some screen shots.

@waako
Copy link

waako commented Nov 28, 2023

Transparency is our friend here, rather than having a default colour set from the --border variable.
Maybe introducing a new variable: --border-transparent: 1px solid, to be used in other places this crops up.

So we end up with --header-search-input-border: var(--border-transparent).

Header with the 1px transparent border, more or less invisible and shouldn't affect existing sites (where not overriden):
Test site Header, search input has transparent border
What that gives in Windows High Contrast Mode:
Test site Header and windows high contrast mode, search input has visible border

new variable for borders of header search input boxes to make them visible in Windows High Contrast Mode.
@bisd bisd self-assigned this Nov 29, 2023
@bisd
Copy link
Member Author

bisd commented Nov 29, 2023

I have tried to implement what has been suggested by @waako. The branch has been updated.

css/base/variables.css Outdated Show resolved Hide resolved
inserted default border variables to define --border-transparent variable.
@markconroy markconroy merged commit ee60a18 into 1.x Dec 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search form box on site not visible in Windows High Contrast Mode
4 participants