Hide the 'files' tab to non admins

[markconroy]

The files tab is pretty much meaningless to content designers, they need the 'media' tab.

Let's hide it for all, except admin users.

[willguv]

@MariosORION this is related to the tab weights work you've just done, so might be quick for you - thanks

[markconroy]

@willguv we have a PR for this - #221 - but the other core team members think we should not do this for existing sites.

[willguv]

OK, we should explain how to do it though.

Can it be for new installs?

Is making this change in config a dev job?

[markconroy]

I think it would be good to have it removed for new installs.

For existing sites, it would then mean a developer would have to remove that permission for whatever current roles we don't want it on.

Here's the Merge Tuesday notes for it: #221 (comment)

[MariosORION]

Thanks both @markconroy, assigning back to @willguv for now.

[willguv]

@markconroy Does this remove the ability for content designers to fully delete files? If so, we will need to review

@finnlewis mentioned caching causing problems. Maria at Bracknell Forest mentioned the need to instantly delete files when it's really necessary, and has a fix

@stephen-cox mentioned a setting for how long temporary files are kept. When a file is deleted in Drupal it's marked for deletion and done later

Andy says they have a checkbox for users to select when deleting a media item to delete the underlying files as well

[andybroomfield]

Media file delete?
(Might be in the default install already).

[andybroomfield]

The module is called media file delete