removes access files overview permission #221
Conversation
| function _remove_access_files_overview_permission() { | ||
| $roles = Role::loadMultiple(); | ||
| foreach ($roles as $role) { | ||
| if ($role->hasPermission('access files overview')) { | ||
| $role->revokePermission('access files overview'); | ||
| $role->save(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not so sure of this, if there are custom roles that have been assigned this then they will get deleted. Sometimes it is useful if there are files which for what ever reason are not yet in media. I'd limit this to localgov drupal provided roles, and I'd check if they have been altered from default. Noting the update hook also runs this.
|
As @andybroomfield points out - there are potential issues removing this permission for existing sites. Maybe just remove the update hook. We could always add a release note suggesting existing sites do this manually if it's important. |
|
Just discussing in Merge Tuesday. Generally happy to remove the permission for fresh installs. However, deploying an update hook that removes permissions from existing roles is perhaps a bit too far. Perhaps we should remove the permission in the default install, and add instructions for people to clarify that they can remove the permission for certain roles. |
|
Note: would like to check where the permission 'access files overview' is being set to see if we can remove it there rather than here. |
Closes #220
Removes the permission to access the files overview permission. It's probably only developers that need this for debugging things, so we can add that manually when needed, or add it to the admin role (when we have one).
===
Thanks to Big Blue Door for sponsoring my time to work on this.