Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media_library_edit to allow media items to be edited after they'v… #146

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

msayoung
Copy link
Member

…e been uploaded

@andybroomfield
Copy link
Contributor

Question, should this be added to the profile instead of core?
As its adding something as a standard experince, but there is nothing in localgov_core that would depend on it?
Although I think the other content types will need to be updated to use media_library_edit as the field widget.

Otherwise its a good call, we use it at BHCC as its odd it doesn't do this be default.

@msayoung
Copy link
Member Author

Hi @andybroomfield
There is an issue to get the functionality in to Drupal core, and a patch that we could use. https://www.drupal.org/project/drupal/issues/2985168
It's been delayed though, pending input from the UX and a11y teams.

I put this in localgov_core as the localgov_media submodule lives here. But happy to move it if that's better.

There's another PR for adding this to localgov_paragraphs - and if these two go in, I'll update localgov_news and localgov_events also. I think this should cover it, but there may be more.

@finnlewis
Copy link
Member

I think we should add it here. The fact that we have submodules means we need to add dependencies for those submodules to our project composer.json. Either that or split out the submodules. So far we've been opting for the former.

@msayoung msayoung marked this pull request as ready for review September 26, 2022 09:56
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this! Thanks @msayoung and @andybroomfield ! :)

Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per merge Monday, as used by other modules.

To consider in future if localgov_media should be own module.

@msayoung msayoung merged commit 65c5c3e into 2.x Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants