Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install optional config in localgov_media at module install time #173

Merged
merged 1 commit into from
May 15, 2023
Merged

Install optional config in localgov_media at module install time #173

merged 1 commit into from
May 15, 2023

Conversation

stephen-cox
Copy link
Member

Fixes #172

ekes
ekes approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been wracking my brain for any issues this might cause.
Can't think of one.
So nice. Will this also mean that we can safely fix all the other optional configs without worrying about media too!

@stephen-cox stephen-cox merged commit be9fab1 into 2.x May 15, 2023
8 checks passed
@stephen-cox stephen-cox deleted the fix/2.x/172-install-optional-media-config branch May 15, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekes ekes ekes approved these changes

@finnlewis finnlewis Awaiting requested review from finnlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix media config installation
2 participants
@stephen-cox @ekes