Workflows permissions and transitions #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthor, contributor and editor roles using the Role Delegation module (#92)
7 tasks
stephen-cox
requested review from
Adnan-cds,
andybroomfield and
finnlewis
and removed request for
msayoung
|
The functionality of the work hear has been tested and reviewed on #92 so this is ready for a code review; which is mainly tests. |
finnlewis
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
I'm happy with this. I've tested it locally and read the config and code.
Would be good to get an OK from @andybroomfield or @Adnan-cds - based on the discussion on #111 we plan to get this work in first, then split off the localgov_workflows as a separate module.
| $en_node = $node_storage->loadRevision($node_storage->getLatestRevisionId($en_node->id())); | ||
| $cy_translation = $en_node->getTranslation('cy'); | ||
| $this->assertEquals('archived', $en_node->moderation_state->value); | ||
| $this->assertEquals('published', $cy_translation->moderation_state->value); |
There was a problem hiding this comment.
I like this testing of translations @stephen-cox, protecting the future!
andybroomfield
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Ok as per #111 this is split out when localgov_workflow is made its own module.
stephen-cox
added a commit
to localgovdrupal/localgov_workflows
that referenced
this pull request
Jul 14, 2021
* Added contributor role and updated workflow permissions (localgovdrupal/localgov_core#92) * Added User Manager role with permissions to create users and assign author, contributor and editor roles using the Role Delegation module (localgovdrupal/localgov_core#92) * Updated permissions and added tests for workflow transitions and translated content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds contributor and user manager roles to localgov_roles and updates default permissions assigned to all roles in localgov_workflows.
Closes #92