Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #213 #214

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Fix for #213 #214

merged 2 commits into from
Jul 27, 2022

Conversation

ekes
Copy link
Member

@ekes ekes commented Jul 26, 2022

No description provided.

@ekes
Copy link
Member Author

ekes commented Jul 26, 2022

If someone can double check this. I just realized I'm not 100% sure that module exists is returning the correct value when it has just been enabled in the previous update, my db might not have been clean by that point.

Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the issue for me.

Running 8007 and then 8008 seperately works with the module check, but
not when both are run consecutively in the same call. Reseting module
list didn't help.
@ekes
Copy link
Member Author

ekes commented Jul 26, 2022

Same update as search to make sure it's good if your ran 8007 and 8008 in one go, as well as separately.

@andybroomfield
Copy link
Contributor

@ekes ekes merged commit 3f8a936 into 2.x Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants