Add template to render directory facets as dropdowns #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-cox
changed the title
stephen-cox
changed the title
stephen-cox
requested review from
Adnan-cds,
andybroomfield,
ekes and
markconroy
|
Hi Steve, The label is actually there but hidden by the facets module. Don't know why. |
I noticed this too. Not sure why the Facets module is intentionally hiding labels. I have updated the Twig template so labels now display |
Adnan-cds
approved these changes
Sep 23, 2022
templates/facets-item-list--dropdown--localgov-directories-facets.html.twig
Outdated
Show resolved
Hide resolved
finnlewis
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Tested locally and works for me. I see the lables too.
Thanks @stephen-cox and @Adnan-cds !
markconroy
approved these changes
Sep 26, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows directory facets to be configured as dropdowns.
Fixes #231