Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error if the block does not exist to suppress error on install. #250

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

finnlewis
Copy link
Member

Fixes #194 and #249 which is a problem for LocalGov Microsites fresh install.

@finnlewis
Copy link
Member Author

I can confirm that this suppresses the error mentioned in #249.

@finnlewis
Copy link
Member Author

@Adnan-cds you OK with this?

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Finn,
Yes, I am okay with this change.

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@finnlewis finnlewis merged commit 3756279 into 2.x Dec 1, 2022
@finnlewis
Copy link
Member Author

Thanks @Adnan-cds and @stephen-cox - merged! I'll tag a release to suppress the error on fresh installs of microsites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants