Add update hook to add pathauto pattern should it not exist yet #254.

[ekes]

To test:

• Install version of localgov_directory_promo_page before e142ff2 so current 2.3.7 version will do.
• Enable localgov_directory_promo_page module
• Then switch to this branch and run updb

The pathauto pattern should be exactly the same, as installing from scratch at HEAD.

Stretch goal. Do the same with a pathauto pattern added, it shouldn't change.

[andybroomfield]

This worked for me, testing the scenario whereby installing without the pattern and them running drush updb now adds the correct pattern.

I havn't tested the scenario whereby a pattern had been already set up, as this would only test the machine name anyway both patterns may end up present and site builders would have to sort out which one to keep.

[finnlewis]

Discussing at Merge Monday. @andybroomfield pointed out that this loads the url alias pattern based on machine name.

If someone has already created a path auto pattern manually, this will currently introduce a duplicate.

We could cover this in release notes, but probably better to try to load a path auto pattern that matches on content type = directory promotional page.

@ekes thinks this is possible - just needs looking at.

[ekes]

Manual testing pattern:-

Install (without this branch). Then
a) just switch to this branch and upgrade you should get the pathauto pattern;
Repeat but this time
b) create a path auto pattern machine name anything you like for the promo page; then switch to this branch and upgrade; you shouldn't get the pathauto pattern.

[finnlewis]

Thanks, I will test

[finnlewis]

Yes mate, this works a treat! Confirmed that it adds the pathauto pattern if one does not exists and a pattern is already there for the localgov_directory_promo_page, it leaves it well alone.

Nice one @ekes ! I'll merge this and prep the release for review on Monday as discussed.