Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update views schema for failing tests #263

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Update views schema for failing tests #263

merged 1 commit into from
Feb 13, 2023

Conversation

stephen-cox
Copy link
Member

Fixes #262

ekes
ekes approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass - they do - this is just what we need. The changed config rings with my memory I'd expect reset map to reappear somewhere, but we don't use it, so that's not a issue.

finnlewis
finnlewis approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah baby, beautiful! Thanks @stephen-cox !!!

@finnlewis
Copy link
Member

But let's get this merged and do a release today to fix failing tests on other pull requests like localgovdrupal/localgov_project#107

@stephen-cox stephen-cox merged commit 5d064f3 into 2.x Feb 13, 2023
@stephen-cox stephen-cox deleted the fix/2.x/262-failing-tests branch February 13, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekes ekes ekes approved these changes

@finnlewis finnlewis finnlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests failing with: Schema errors for views.view.localgov_directory_channel with the following errors
3 participants
@stephen-cox @finnlewis @ekes