Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make facets on a channel optional, as is documented from #281. #291

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ekes
Copy link
Member

@ekes ekes commented Jun 26, 2023

Doing dev on a channel that doesn't use content facet, but taxonomy facets instead, and keep getting reminded this field isn't actually compulsory. So figured rather than unticking it every time I reinstall I should make a PR :)

Doing dev on a channel that doesn't use content facet, but taxonomy
facets instead, and keep getting reminded this field isn't actually
compulsory. So figured rather than unticking it every time I reinstall I
should make a PR :)
@ekes
Copy link
Member Author

ekes commented Jun 26, 2023

(should actually be applied to 2.x and 3.x if merged)

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks trivial enough to me!

@ekes ekes merged commit 7ab003d into 2.x Jun 26, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants