Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run core update for our blocks added after the fact. #296

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

ekes
Copy link
Member

@ekes ekes commented Jul 7, 2023

As per comment in the code. We've added config with deprecated plugin after the core update. So this just runs it again. Doing so in all the modules we added this config would make sense.

This does to existing sites what 8d9c891 did for new installs.

@stephen-cox
Copy link
Member

This is needed for the 3.0.0-alpha1 release of the profile: localgovdrupal/localgov#588

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@finnlewis
Copy link
Member

Merging in Ekes's absence, to help with fixing tests.

@finnlewis finnlewis merged commit 8842219 into 3.x Jul 10, 2023
1 of 4 checks passed
@markconroy
Copy link
Member

Looks like if you have a block that was removed, then this update is putting that block back in place again.

For example, on a directory channels if you don't want the map, so removed that block, then run this update the map comes back in again - just had a report of this happening on a client site.

I wonder could we make the code a little more secure to only update/reset blocks that have not be removed/edited? Or at least see if we could make this a consideration if we need to run a similar update on our other modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants