Fix: Suppress PHP 8.1 and 8.2 deprecation warnings #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adnan-cds
requested review from
ekes,
finnlewis,
andybroomfield and
stephen-cox
stephen-cox
approved these changes
Sep 29, 2023
|
Thanks a lot for the approval. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callable names like
static::fooare now deprecated. So are use of undeclared dynamic object properties.@see https://www.php.net/releases/8.1/en.php#first_class_callable_syntax
@see https://www.php.net/releases/8.2/en.php#deprecate_dynamic_properties
The contrib facets module is also flooding Drupal logs with deprecation notices about dynamic property usage. There's even a ticket for it. Not sure when that'll be merged. It doesn't help that the patch is for facets:3.x whereas localgov_directories relies on facets:2.x which is also the stable branch.