fix: phpstan issues #316
Merged
fix: phpstan issues #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
finnlewis
approved these changes
Sep 30, 2023
|
woops - approved the wrong one, sorry, too many tabs! |
Adnan-cds
approved these changes
Oct 2, 2023
| @@ -215,7 +215,7 @@ public function insertedTitleSortField(FieldConfigInterface $field): void { | |||
| */ | |||
| public function importConfigEntity(string $entity_type, string $config_path, string $config_filename): bool { | |||
| $config_src = new ConfigFileStorage($config_path); | |||
| if (empty($config_src)) { | |||
| if (!$config_src instanceof ConfigFileStorage) { | |||
There was a problem hiding this comment.
It's unfortunate we are having to go through all these gymnastics simply because of a bug in PHPStan. This one, for example, reduces the readability of the code by a tiny amount :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues reported in #315