Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo election content #31

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Add demo election content #31

merged 4 commits into from
Jun 21, 2024

Conversation

stephen-cox
Copy link
Member

Fixes #28

@stephen-cox stephen-cox changed the title Added demo election content Add demo election content Jun 20, 2024
@markconroy
Copy link
Member

markconroy commented Jun 20, 2024

@stephen-cox this looks great, but is also creating duplicate taxonomy terms for anyone who already has the localgov_elections_uk_parties module installed.

Do you think we could get this to use the UK Parties module for the taxonomy terms instead of generating new ones? Or, failing that, delete the generated nodes/terms when uninstalling this module?

Screenshot 2024-06-20 at 16 41 28

@finnlewis
Copy link
Member

note: want to check if we can remove the content when uninstalling the module

@finnlewis
Copy link
Member

finnlewis commented Jun 21, 2024

@markconroy I've added '(demo content' to the term labels for now.

image

Looks like there is a drush command in the pipeline to remove content on uninstall, see https://www.drupal.org/project/default_content/issues/3282547

For now there is not much content, so I think it would be easy enough to remove the demo content if desired.

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it so much easier to test, thanks @stephen-cox !

@finnlewis
Copy link
Member

Not sure why the tests are getting a 500 server error here, they all still pass locally.

@finnlewis finnlewis merged commit 2551bf5 into 1.x Jun 21, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo content module
3 participants