Fix: Account for deleted parties #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for the possibility that one or more parties could be deleted. This is a possibility during testing and training. Resolved #37
|
I'm not comfortable with this approach as it means a taxonomy term could be deleted and impact a historical election. I think it is much better to prevent deletion if a term is in use. |
Good morning :) I think that's somewhat of a feature request which can be implemented in a different ticket. What I have done in this change is to apply some defensive programming to prevent WSOD when Editors are practising to get a taste of this module. |
finnlewis
approved these changes
Jul 1, 2024
@dedavidson let's track that here #75 |
|
Thanks. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for the possibility that one or more electoral parties could be deleted. This is particularly a possibility during testing and training.
Resolved #37