Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show votes only when finalised #70

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Show votes only when finalised #70

merged 5 commits into from
Jul 2, 2024

Conversation

dedavidson
Copy link
Contributor

Enter some results, finalise the vote, save and then reverse the final vote, save, the votes will continue to show on Ward Results table on Summary page. This fixes it.

@chriswales95
Copy link
Member

@dedavidson I think you said earlier this wasn't quite ready. Maybe should mark as draft?

Copy link
Member

@chriswales95 chriswales95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking reviewed for now until it's finished.

@dedavidson dedavidson marked this pull request as draft June 28, 2024 18:19
@finnlewis
Copy link
Member

What's left to do on this one @dedavidson ?

@dedavidson
Copy link
Contributor Author

Its whether it needs an update hook to update the view for those already installed.

@finnlewis
Copy link
Member

We could just explain in the release notes how to update the view, it looks fairly straight forward.

@dedavidson dedavidson marked this pull request as ready for review July 2, 2024 10:53
@finnlewis finnlewis merged commit 7e67428 into 1.x Jul 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Votes in Summary Ward Results table always show after votes finalised
3 participants