-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renames social post module #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and all works.
Assume existing installs will need to uninstall sub-module before applying update? So it will be "breaking" change?
@dedavidson I think we probably know who is using this module at the moment, so maybe message each to ask them to uninstall it if they have it installed? Failing that, I guess we can come up with a step-by-step
|
@markconroy sounds like a plan. Just need to make clear in release notes and promote on slack |
PR updated to
=== |
@dedavidson I was just commenting on the issue, see #62 (comment) Might we want to take this opportunity to rename modules to be consistent with parent / child naming conventions? localgov_elections_reporting or even rename the parent module to localgov_elections |
I'm in favour of localgov_elections if it's not too much work |
I'd prefer to keep reporting or something similar in the name as the module doesn't run elections it just reports on them. |
Discussing in Merge Tuesday, we would like to have a breakout meeting about this. Do we have time to rename things now and save tech debt? |
...s/localgov_elections_reporting_social_post/localgov_elections_reporting_social_post.info.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package for new module needs changed but otherwise all good from local testing
Hi @dedavidson That change is made now, can you give this one final check and mark it approved if you're happy with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
Closes #62
===
Thanks to Big Blue Door for sponsoring my time to work on this.