Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renames social post module #63

Merged
merged 6 commits into from
Jun 19, 2024
Merged

renames social post module #63

merged 6 commits into from
Jun 19, 2024

Conversation

markconroy
Copy link
Member

@markconroy markconroy commented Jun 12, 2024

Closes #62

===
Thanks to Big Blue Door for sponsoring my time to work on this.

Copy link
Collaborator

@dedavidson dedavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and all works.

Assume existing installs will need to uninstall sub-module before applying update? So it will be "breaking" change?

@markconroy
Copy link
Member Author

@dedavidson I think we probably know who is using this module at the moment, so maybe message each to ask them to uninstall it if they have it installed?

Failing that, I guess we can come up with a step-by-step

  1. mark old module deprecated
  2. uninstall old module
  3. install new module
  4. next release remove old module

@dedavidson
Copy link
Collaborator

@markconroy sounds like a plan. Just need to make clear in release notes and promote on slack

@markconroy
Copy link
Member Author

PR updated to

  1. Leave the original module in place
  2. Mark the original module as deprecated
  3. Uninstall the original module if the new module is being installed

===
Thanks to Big Blue Door for sponsoring my time to work on this.

@finnlewis
Copy link
Member

@dedavidson I was just commenting on the issue, see #62 (comment)

Might we want to take this opportunity to rename modules to be consistent with parent / child naming conventions?

localgov_elections_reporting
localgov_elections_reporting_soical_posts

or even rename the parent module to

localgov_elections
localgov_elections_social_posts

@willguv
Copy link
Member

willguv commented Jun 17, 2024

I'm in favour of localgov_elections if it's not too much work

@dedavidson
Copy link
Collaborator

I'd prefer to keep reporting or something similar in the name as the module doesn't run elections it just reports on them.

@finnlewis
Copy link
Member

Discussing in Merge Tuesday, we would like to have a breakout meeting about this.

Do we have time to rename things now and save tech debt?

Copy link
Collaborator

@dedavidson dedavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package for new module needs changed but otherwise all good from local testing

@markconroy
Copy link
Member Author

Hi @dedavidson

That change is made now, can you give this one final check and mark it approved if you're happy with it.

Copy link
Collaborator

@dedavidson dedavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@markconroy markconroy merged commit b21ccee into 1.x Jun 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename social post module
4 participants