No longer need patch for geofield schema

[finnlewis]

It looks like the patch was committed :
https://git.drupalcode.org/project/geofield_map/-/commit/6642265c136329ce04ebda7bccd1b208919f5e4e

[Adnan-cds]

Thanks Finn. Now that this issue is resolved, would you mind doing the honour of adding a release tag for localgov_geo such as 1.0.1-alpha1? :)

[finnlewis]

I think it should bt 1.0.0-alpha2 up until we have the 1.0.0 release.

From experience I think that is more the Drupal way.

Thoughts? @ekes @stephen-cox @andybroomfield

[finnlewis]

Sorry, cross posting from localgovdrupal/localgov#139

But here's an example of how I expect the increments to flow :

1.0.1 - 23 July 2020
1.0.0 - 6 July 2020
1.0.0-alpha6 - 25 June 2020
1.0.0-alpha5 - 23 June 2020
1.0.0-alpha4 - 23 June 2020
1.0.0-alpha3 - 23 June 2020
1.0.0-alpha2 - 22 June 2020
1.0.0-alpha1 - 21 June 2020
1.0.x-dev - 21 June 2020

[stephen-cox]

The Drupal way would be to release 1.0.0-alpha2 next. I have to admit that I find this a little strange, but I think we decided to do things this way.

As mentioned here localgovdrupal/localgov#139 (comment), we need a list of conditions that might cause a new release. In my view, a minor fix isn't enough to trigger a new release on it's own, but we do need to decide on what conditions need to be met to trigger a new release.

[finnlewis]

I think a bug fix perhaps should trigger a release, as people might need that fix downstream. But is a bug fix anything that causes tests to fail?

In our immediate case, Lambeth is launching next Tuesday, so we need to be able to pull in as many of the bug fixes that occur this week as possible.

[finnlewis]

OK - tagged this with 1.0.0-alpha2

https://github.com/localgovdrupal/localgov_geo/releases/tag/1.0.0-alpha2

[stephen-cox]

I assume this is only causing an warning with Composer so it's not breaking the site or causing builds to fail? In which case it's very minor and in my view not worth creating a new release for.

[Adnan-cds]

I assume this is only causing an warning with Composer so it's not breaking the site or causing builds to fail?

I really don't know Steve. Gosia's tests are failing with Schema errors from the localgov_geo module. This is very odd. Now that Finn has made a new release, I will trigger the failing test again and see if this makes any difference.

[Adnan-cds]

Gosia's test has failed again. But looks like this time the missing Schemas are from the geofield module and I can't find a patch. It may be a coincidence that these tests failed on the same day the change for this issue was merged.

FAO @finnlewis @stephen-cox @gosia-mlynarczyk

[ekes]

Is this still an issue?

[Adnan-cds]

I think this one can be closed.