Fix: Access to Geo overview page #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-admin users with the "Access geo overview page" permission are unable to access the Geo overview page at the moment. Here we resolve it by assigning this permission as the admin_permission for Geo entities.
|
@Adnan-cds and @ekes discussed this at Merge Monday. Interesting discussion on https://www.drupal.org/project/drupal/issues/2938889 @Adnan-cds will write some tests to clarify expected behaviour and @ekes will review and approve when ready. |
Added a Functional test. Also fixed deprecation errors.
|
I have added a small Functional test to check if users with the |
finnlewis
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Discussing with @ekes and @Adnan-cds on merge Monday call, all tests pass and we've got some new tests. Good to go we reckon!
|
Thanks Finn. Merging... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-admin users with the "Access geo overview page" permission are unable to
access the Geo overview page at the moment. Here we resolve it by assigning
this permission as the
admin_permissionfor Geo entities.How to test