Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch for leaflet_views schema fixes. #7

Merged
merged 4 commits into from
Sep 15, 2020

Conversation

finnlewis
Copy link
Member

No description provided.

@finnlewis
Copy link
Member Author

@stephen-cox I rerolled the patch on https://www.drupal.org/project/leaflet/issues/2883700 to include your changes and new ones. Locally this applies fine and the tests all pass.

Not sure why the testing here has failed once, it seemed to fail on trying to apply the patch.

Perhaps you could test the patch if it fails again, and comment on the issue on drupal.org?

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@finnlewis finnlewis merged commit 58834be into master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants