Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guides test to account for new page header #137

Closed
andybroomfield opened this issue Dec 2, 2023 · 0 comments · Fixed by #138
Closed

Update guides test to account for new page header #137

andybroomfield opened this issue Dec 2, 2023 · 0 comments · Fixed by #138
Labels
good first issue Good for newcomers

Comments

@andybroomfield
Copy link
Contributor

Main tests are now failing due to the change in the page header merged in localgovdrupal/localgov_core#193.

So the guides test needs to be updated to account for the newline in the markup, as per the test in localgov_core.
@andybroomfield andybroomfield added good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Dec 2, 2023
andybroomfield added a commit that referenced this issue Dec 7, 2023
@andybroomfield
Update page header test to account for markup change in core header b…
ad480e5 
…lock

Fix #137

Use xpath to check for the page title is inside the header, as the template
now contains newlines.
@andybroomfield andybroomfield mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@andybroomfield