Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test #242

Merged
merged 1 commit into from Sep 26, 2022
Merged

Fix failing test #242

merged 1 commit into from Sep 26, 2022

Conversation

stephen-cox
Copy link
Member

Fixes #241

msayoung
msayoung approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@msayoung msayoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy that it fixes the test.
I assume that it still works fine.

@stephen-cox stephen-cox merged commit a60c57e into 1.x Sep 26, 2022
@finnlewis
Copy link
Member

Nice one @stephen-cox and @msayoung !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msayoung msayoung msayoung approved these changes

@ekes ekes Awaiting requested review from ekes

@finnlewis finnlewis Awaiting requested review from finnlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test
3 participants
@stephen-cox @finnlewis @msayoung