Disable Groups Terms view #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekes
reviewed
Mar 31, 2023
There was a problem hiding this comment.
If you're sure the group_term module is enabled by this point, even if the optional configuration hasn't been imported, is it possible to use the view from the module rather than duplicating it?
There was a problem hiding this comment.
I thought that the view defined in the group_term module might get changed in some incompatible way so I figured I would take a copy that won't get installed unless our code calls it.
|
@ekes is happy and @stephen-cox is keen to get this merged and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
Fixes #393