Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing or overriding font awesome dependancy #123

Open
andybroomfield opened this issue Feb 3, 2023 · 2 comments
Open

Removing or overriding font awesome dependancy #123

andybroomfield opened this issue Feb 3, 2023 · 2 comments
Labels
question Further information is requested

Comments

@andybroomfield
Copy link
Contributor

andybroomfield commented Feb 3, 2023

This is a followup to #39 and #47.
The issue has come up as we are trying to replace font awesome use on our site with our own icon set.
As far as I can tell this is only a requirement of the submodule localgov_homepage_paragraphs in order to provide the paragraph localgov_ia_block.
Since this is a submodule, do we need the hard requirement to install fontawesome provided by composer.json, could we not move this to composer suggest? (We'd have to add a release note exaplaining that if you use this paragraph type, you need to install this manually to keep it.
Checking the dependancy chain, it's then required by localgov_subsites_paragraphs and then by localgov_subsites.

For the moment, we can disable loading the fontawesome library so it's not a super urgernt deal, but it is another module we are getting installed without really needing it.

So would we be able to remove the dependancy, and would that nessacitate a breaking change needing a major release?

@andybroomfield andybroomfield added the question Further information is requested label Feb 3, 2023
@andybroomfield
Copy link
Contributor Author

Note the localgov_ia_block was for creating the icons as seen on the BHCC homepage, which is where I think they originated from, though I think only BHCC implemented using them, not sure how they got tied to Subsites.

@ekes
Copy link
Member

ekes commented Feb 6, 2023

I think removing the requirement would require people putting it in the their composer.json
Is this easiest done along with other things that's going to require a version bump... ie along with the D10 upgrade? #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants