Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change font awesome to 2.18 #47

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Change font awesome to 2.18 #47

merged 1 commit into from
Apr 25, 2022

Conversation

andybroomfield
Copy link
Contributor

Fix #39
Instead of pinning to a specific commit hash.
Using 2.18 as that is the release after the commit hash that was pinned.

@andybroomfield
Change font awesome to 2.18
b1dda93 
Fix #39
Instead of pinning to a specific commit hash.
Using 2.18 as that is the release after the commit hash that was pinned.
markconroy
markconroy approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@markconroy markconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except I'd prefer if we weren't loading the whole of font awesome, which is a chat for another day, this looks good to me.

@andybroomfield andybroomfield merged commit 818d700 into 2.x Apr 25, 2022
@finnlewis finnlewis deleted the fix/39-set-fontawesome-to-version branch October 10, 2022 15:04
@andybroomfield andybroomfield mentioned this pull request Feb 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markconroy markconroy markconroy approved these changes

@Adnan-cds Adnan-cds Awaiting requested review from Adnan-cds

@finnlewis finnlewis Awaiting requested review from finnlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't request Font Awesome from a specific commit hash
2 participants
@andybroomfield @markconroy