New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation error in CI #163
Comments
Actually, I think I got a little ahead of myself here. It looks like ByteSizeMarkup::create() only got introduced in 10.2, so we don't want to merge this until we're happy to drop support for 10.1. |
Suggest we add |
Good plan. I'm also wondering if we can make a failure on the deprecated code check into a warning instead of an error. I know how to do this on GitLab CI, but not GitHub actions. |
I agree with @andybroomfield we should use // FIXME: Replace with ByteSizeMarkup, when Drupal 10.1 is end of life.
// @phpstan-ignore-next-line. |
See here: https://github.com/localgovdrupal/localgov_paragraphs/actions/runs/7426621431/job/20210755941
The text was updated successfully, but these errors were encountered: