Removed call to deprecated format_size() #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e\StringTranslation\ByteSizeMarkup::create() as per https://www.drupal.org/node/2999981.
|
As noted on the issue ByteSizeMarkup class was introduced in Drupal 10.2 so we would need to hold on this until we can set 10.2 as the minimum supported version (when 10.3 is released). |
|
Looking at 17th June 2024 for 10.3.0 to be released and 10.1.x to end security support. |
|
@ekes points out that it's possible to check the version of Drupal can call different functions depending on the version. Should be useful in this case. |
|
Some merge conflict to be resolved. After that, what shall we do with this @rupertj ? Hang tight like @andybroomfield suggests or write something to check the version like @stephen-cox mentions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced with Drupal\Core\StringTranslation\ByteSizeMarkup::create() as per https://www.drupal.org/node/2999981.
Fixes #163.