Making composer install /vendor/bin in the usual place and providing a link for /bin. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option would be to fix the ddev and Lando configs (and GitHub Actions) so you don't need the composer line setting the bin dir at all? |
|
@andybroomfield just mentioned that Acquia expects it to be in /vendor/bin. |
|
This is with Cloud next and cloud actions, after a call with an Acquia engineer. We're making that change to our composer.json to align with Acquia expectations, otherwise cloud actions fail as it can't find drush. As mentioned above this only affects new projects so we will need to document that change and rational for it. |
|
Closing this in favour of #143 , thanks @gregharvey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Because lots of CI expect to find tools like
drushinvendor/bin, it's thecomposerstandard. I presume Lando needs the./bindirectory to contain these tools so it can present them? This solution attempts to make that available for Lando by committing a link, while allowing composer to install things in the "usual" places.I understand if you don't accept this, it's just a suggestion and it only took a minute to make. :-)