Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/27 composer 2 fix #28

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Feature/27 composer 2 fix #28

merged 3 commits into from
Nov 4, 2020

Conversation

finnlewis
Copy link
Member

No description provided.

composer.json Outdated Show resolved Hide resolved
@finnlewis
Copy link
Member Author

@Adnan-cds there are no CI tests running on this repo.
Is that by intention?
Shall we add them or you happy to merge this and test the whole lot locally against composer2?

@Adnan-cds
Copy link
Contributor

Is that by intention?

I don't know :)

Shall we add them or you happy to merge this and test the whole lot locally against composer2?

Let me try locally and get back to you shortly.

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me when I tried the following:

$ ./composer --version
Composer version 2.0.4 2020-10-30 22:39:11
$ ./composer create-project --stability dev --no-cache localgovdrupal/localgov-project:dev-feature/27-composer-2-fix

Thanks :)

@finnlewis finnlewis merged commit 1c2979b into master Nov 4, 2020
@stephen-cox stephen-cox deleted the feature/27-composer-2-fix branch May 27, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants