Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added form validation to ensure that publication pages are always in a book. #114

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Added form validation to ensure that publication pages are always in a book. #114

merged 2 commits into from
Nov 30, 2023

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented Nov 15, 2023

Fix for #33

@finnlewis
Copy link
Member

@agile-simon fancy testing this one?

@finnlewis
Copy link
Member

@agile-simon might you have time to review this?

Or @stephen-cox are you back yet? 😄

agile-simon
agile-simon approved these changes Nov 28, 2023
View reviewed changes
Copy link

@agile-simon agile-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, tested locally and works as expected. Arguably don't need a 'please in the error message per GDS guidelines, not sure how consistently that is applied though.

@rupertj
Copy link
Member Author

rupertj commented Nov 30, 2023

Great - thanks Simon!

@rupertj rupertj merged commit 07ae864 into 1.x Nov 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agile-simon agile-simon agile-simon approved these changes

@stephen-cox stephen-cox Awaiting requested review from stephen-cox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rupertj @finnlewis @agile-simon