-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1.x/7 publication page content type #22
Merged
jbloomfield
merged 20 commits into
1.x
from
feature/1.x/7-publication-page-content-type
Mar 14, 2023
Merged
Feature/1.x/7 publication page content type #22
jbloomfield
merged 20 commits into
1.x
from
feature/1.x/7-publication-page-content-type
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent. Added default block placement.
# Conflicts: # config/optional/block.block.localgov_publications_toc_block.yml
finnlewis
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Notes:
- we proably want to remove composer.lock from this repo and add it to gitignore.
- I've added this repo to packagist, so we can now composer require branches t o test like:
lando composer require localgovdrupal/localgov_publications:dev-feature/1.x/7-publication-page-content-type
Cheers @finnlewis I have removed composer.lock and added it to .gitignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.