Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL alias patterns #66

Merged
merged 8 commits into from
May 18, 2023
Merged

URL alias patterns #66

merged 8 commits into from
May 18, 2023

Conversation

j4-m
Copy link
Contributor

@j4-m j4-m commented May 4, 2023

Relates to #61

@j4-m j4-m changed the title WIP: Adds the URL alias for publication landing pages. WIP: URL alias patterns May 4, 2023
j4-m added 3 commits May 18, 2023 12:13
The new Entity Reference field uses a Views Entity Reference widget so that only Publication pages which are 'top level' can be referenced.
@j4-m j4-m changed the title WIP: URL alias patterns URL alias patterns May 18, 2023
@j4-m j4-m requested a review from finnlewis May 18, 2023 13:59
@@ -4,6 +4,7 @@ dependencies:
config:
- field.field.node.publication_landing_page.body
- field.field.node.publication_landing_page.field_localgov_services_landing
- field.field.node.publication_landing_page.field_publication
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pedant, but I think we probably want to follow the localgov_ field prefix convention for all our fields.


$this->drupalGet('/publications/test-publication-landing-page/publication-parent-page');
$this->assertSession()->statusCodeEquals(200);
$this->drupalGet('/publications/test-publication-landing-page/publication-parent-page/publication-child-page');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

@finnlewis finnlewis merged commit ae23ea8 into 1.x May 18, 2023
8 checks passed
@rupertj rupertj deleted the feature/1.x/61-url-aliases branch August 17, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants