Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved logic to get the root level of a publication out to a new service so we can re-use it. Fixes cache bug. #78

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Moved logic to get the root level of a publication out to a new service so we can re-use it. Fixes cache bug. #78

merged 7 commits into from
Jun 21, 2023

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented Jun 16, 2023

No description provided.

@rupertj rupertj requested a review from finnlewis June 18, 2023 18:50
finnlewis
finnlewis approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry not to get to this sooner. Tested locally and works nicely.

Coding standards pass too! Thanks @rupertj !

@finnlewis finnlewis merged commit 8a3c2d2 into 1.x Jun 21, 2023
8 checks passed
@rupertj rupertj deleted the fix/1.x/77-PublicationPageHeaderBlock-cache branch August 17, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rupertj @finnlewis